Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Aqua to ensure project quality #270

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 9, 2022

Removes an unbound type parameter in a _lu method.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 80.47% // Head: 80.47% // No change to project coverage 👍

Coverage data is based on head (6284e0b) compared to base (d82cd4f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   80.47%   80.47%           
=======================================
  Files          23       23           
  Lines        3258     3258           
=======================================
  Hits         2622     2622           
  Misses        636      636           
Impacted Files Coverage Δ
src/banded/BandedLU.jl 64.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Project.toml Show resolved Hide resolved
@jishnub
Copy link
Member Author

jishnub commented Sep 16, 2022

Gentle bump, should this be ok to merge? cc @dlfivefifty

@jishnub
Copy link
Member Author

jishnub commented Sep 26, 2022

Gentle bump

Copy link
Contributor

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a member of this repo, but I would approve of this PR.

@dlfivefifty dlfivefifty merged commit 4d64161 into JuliaLinearAlgebra:master Sep 26, 2022
@jishnub jishnub deleted the aqua branch September 27, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants