Markdown: improve handling of horizontal rules #60563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, order it before the "list" rule so that it can take precedence (the symbols `-` or `*` can start both a list and a horizontal rule). Actually, also add it to the GitHub flavor where it was missing, presumably by accident.
tecosaur
approved these changes
Jan 6, 2026
Member
tecosaur
left a comment
tecosaur
left a comment
There was a problem hiding this comment.
It's always nice to see @test_broken replaced with @test. I'm not fussed about underscore rules myself, but the changes to implement them seem reasonable, and there were already tests waiting to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
horizontalruleto fix support for horizontal rules e.g. inside of listsFixes 6 CommonMark spec tests.