Test: add broken/skip/context keywords to all @test_* macros
#60543
+606
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/test_args
branch
2 times, most recently
from
dd2f606 to
b244521
Compare
…test_nowarn, @test_logs, @test_deprecated Add support for broken=, skip=, and context= keyword arguments to additional test macros for consistency with @test. - @test_throws: now supports broken/skip/context keywords - @test_warn/@test_nowarn: now supports broken/skip keywords - @test_logs: now supports broken/skip keywords - @test_deprecated: now supports broken/skip keywords Extract common keyword parsing into extract_broken_skip_kws helper function to reduce code duplication. Co-Authored-By: Claude <noreply@anthropic.com>
IanButterworth
force-pushed
the
ib/test_args
branch
from
bf7b2e6 to
220441f
Compare
Extract common exception-matching logic from do_test_throws and do_broken_test_throws into a shared check_exception_match helper function. This eliminates ~80 lines of duplicated code and ensures both functions use identical matching logic including all edge cases (LoadError deprecation, FieldError deprecation, UndefVarError scope handling, etc.).
IanButterworth
force-pushed
the
ib/test_args
branch
from
0184e09 to
c2717f9
Compare
Member
Author
giordano
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for broken=, skip=, and context= keyword arguments to additional test macros for consistency with
@test.@test_throws: now supports broken/skip/context keywords@test_warn/@test_nowarn: now supports broken/skip keywords@test_logs: now supports broken/skip keywords@test_deprecated: now supports broken/skip keywordsExtract common keyword parsing into extract_broken_skip_kws helper function to reduce code duplication.
Developed with Claude