Fix: llvmcall segfault/parser error with zero-sized arguments #60364
+63
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Base.llvmcall intrinsic previously crashed (Segmentation Fault) or threw a parser error when given a zero-sized type (ZST), such as nothing, as an argument.
This patch addresses two issues in src/ccall.cpp:
Adds a null check (if (!v)) in llvm_type_rewrite to safely handle ghost arguments.
Skips void types when generating the LLVM function signature string in emit_llvmcall, ensuring valid syntax.
The result is that calling llvmcall with a ZST now correctly throws a user error if the user attempts to reference the ZST argument in the custom assembly.
Fixes #60063
I have also included a regression test in test/llvmcall.jl to prevent this issue from recurring.