Don't create a subprocess in the REPL precompile script #60326
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use raw Base.Filesystem.File IO on PTYs in the REPL precompile script. Due to JuliaLang#24440, spawning a subprocess using the REPL's shell mode clears the O_NONBLOCK flag set on the PTY, resulting in deadlocks when libuv later reads or writes to it from Julia code. I haven't identified what caused this to become more of a problem recently, but I don't think some extra compilation latency when starting shell mode is worth it if it's causing mystery timeouts in CI.
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
IanButterworth
added
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use raw Base.Filesystem.File IO on PTYs in the REPL precompile script. Due to #24440, spawning a subprocess using the REPL's shell mode clears the O_NONBLOCK flag set on the PTY, resulting in deadlocks when libuv later reads or writes to it from Julia code. I haven't identified what caused this to become more of a problem recently, but I don't think some extra compilation latency when starting shell mode is worth it if it's causing mystery timeouts in CI.
See also the description of #60141.