trimming: fix-up support for Core._apply_iterate
#60062
Open
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
added
trimming
We only support a few built-in versions of this call (due to JuliaLang#57830), but those should at least be working now with this small tweak. This required a fix-up for built-in functions to be included in the method table for `--trim`'d executables, so that we can dynamically dispatch to them, as the verifier expects.
topolarity
force-pushed
the
ct/fix-apply_iterate
branch
from
58cb358 to
94c9252
Compare
vtjnash
approved these changes
Nov 7, 2025
| jl_value_t *params[2]; | ||
| params[0] = dt->name->wrapper; | ||
| params[1] = jl_tparam0(jl_anytuple_type); | ||
| jl_datatype_t *tt = (jl_datatype_t*)jl_apply_tuple_type_v(params, 2); |
Member
Author
There was a problem hiding this comment.
GC is disabled just a few lines above this, but sure thing
vtjnash
reviewed
Nov 7, 2025
| end | ||
| # TODO: check for calls to Base.atexit? | ||
| elseif isexpr(stmt, :call) | ||
| error = "unresolved call" |
Member
There was a problem hiding this comment.
This makes things less parallel structured here (normally the function sets the error message, then uses continue to skip it, instead of attempting to catch every possible else clause)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only support a few built-in versions of this call (due to #57830), but those should at least be working now with this small tweak.
Includes a fix-up for built-in functions to be included in the method table for
--trim'd executables, so that we can dynamically dispatch to them as the verifier expects.