Add missing dot at the end of sentence #60016
Conversation
Added dot.
giordano
changed the title
|
I changed the title to be slightly more descriptive, referencing "line 39" in a commit message is quite useless. |
|
Happy to merge this, but that whole sentence construction there is a bit unfortunate. |
Yes, I agree It is confusing sentence. Can you suggest correct sentence form of that line? https://julialang.org/blog/2025/10/julia-1.12-highlights/#new_multi-threading_features |
|
|
||
| !!! compat "Julia 1.12" | ||
| Starting by default with 1 interactive thread, as well as the 1 worker thread, was made as such in Julia 1.12 | ||
| Starting by default with 1 interactive thread, as well as the 1 worker thread, was made as such in Julia 1.12. |
There was a problem hiding this comment.
| Starting by default with 1 interactive thread, as well as the 1 worker thread, was made as such in Julia 1.12. | |
| The default number of threads changed in Julia 1.12. Prior versions default to 1 (default thread pool) thread. |
There was a problem hiding this comment.
After Julia 1.12 release Julia by default now starts with one worker thread and one interactive thread that is equivalent of
julia -t1,1(1 default + 1 interactive thread). So nowjulia -t1is equivalent tojulia -t,0that is no interactive thread will be assigned or spawned.
Is my above suggestion better?
There was a problem hiding this comment.
The information is fine, but the wording could use improvement.
There was a problem hiding this comment.
I leave it to experts to make good sentence.
There was a problem hiding this comment.
@giordano Here in the first line should they be replaced by we?
Because finalizers can interrupt any code, they must be very careful in how they interact with any global state.
There was a problem hiding this comment.
No, I think it's fine to personify finalizers.
There was a problem hiding this comment.
What should i do to get this merged? what changes are you waiting for merge?
5 participants
Added dot.