Skip to content

Conversation

@adienes
Copy link
Member

@adienes adienes commented Oct 7, 2025

after #34296 this method is redundant, and it's also undocumented. according to #43491 (comment), Callable should not be used anymore, so it might make sense to remove from Base where feasible.

@adienes adienes added deprecation This change introduces or involves a deprecation collections Data structures holding multiple items, e.g. sets labels Oct 7, 2025
@adienes adienes force-pushed the deprecate_merge_callable branch from 721c52c to fabe509 Compare October 8, 2025 12:57
@adienes adienes added the triage This should be discussed on a triage call label Oct 22, 2025
@LilithHafner
Copy link
Member

LilithHafner commented Oct 23, 2025

From triage: yes, please.

(In general the pattern func(f, collection) where f is called on all the elements of collection before proceeding with func is bad and we wish we had never done that for anything except map)

@LilithHafner LilithHafner removed the triage This should be discussed on a triage call label Oct 23, 2025
@adienes adienes added the needs news A NEWS entry is required for this change label Oct 23, 2025
@adienes adienes added merge me PR is reviewed. Merge when all tests are passing and removed needs news A NEWS entry is required for this change labels Oct 26, 2025
@adienes
Copy link
Member Author

adienes commented Oct 27, 2025

I see the same test failure on other PRs too so it should be unrelated. merging before the 1.13 branch cuts so I don't have to update this again 🙂

@adienes adienes removed the merge me PR is reviewed. Merge when all tests are passing label Oct 27, 2025
@adienes adienes merged commit 5957579 into JuliaLang:master Oct 27, 2025
6 of 9 checks passed
@adienes adienes deleted the deprecate_merge_callable branch October 27, 2025 17:05
Keno pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

collections Data structures holding multiple items, e.g. sets deprecation This change introduces or involves a deprecation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants