-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
only touch non-bundled ji files when loading them #59653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Could we use atime for this rather than mtime (still explicitly bumping the atime here in case the fs is mounted with |
I don't know if that will safely work. We need to read these files to see if they have applicable content, and that will immediately also muck up atime. The comment about atime being stupid seems still quite apropos. |
We're just using a time to tell us which file worked most recently though |
Right, but atime won't tell you that, since it is the most recent time it was examined and possibly failed, not the most recent time it worked |
Well, we could set O_NOATIME on the read side, but regardless my question was primarily about the docker behavior. My concern is that is behavior is not particularly general. As soon as you build a docker container with a bunch of precompile files, the same issue will happen to them in the next layer. I don't think there's anything special about the stdlib files with respect to this, so it seems a bit weird to special case them. |
I had the same thought, but it is only on linux, and even so it gets ignored by various filesystems |
Should fix JuliaLang/Pkg.jl#4120