Make Base.Cartesian public #59459
Merged
Make Base.Cartesian public #59459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilithHafner
added
design
|
closes #58378 |
|
From triage: this module's API has been stable since 1.0. Seems like a good idea to make public. |
|
This seems to have introduced a new test failure in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the stuff in this module has slightly silly but extremely useful API (e.g. the identification of
iin variable names inBase.@nexprs 10 i -> x_i = i). Should we make it public?As a point of reference, nothing more,
@nexprsis already widely used https://juliahub.com/ui/Search?type=symbols&q=@nexprs&t=macroTagging triage for a public API expansion.
closes #58378