Skip to content

[backports-release-1.11] Revert "Make late gc lower handle insertelement of alloca use. (#58637)" #59447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parent: Backports for Julia 1.11.8
wants to merge 1 commit into from
Closed

[backports-release-1.11] Revert "Make late gc lower handle insertelement of alloca use. (#58637)" #59447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/llvm-late-gc-lowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,7 @@ void RecursivelyVisit(callback f, Value *V) {
if (isa<CallInst>(TheUser) || isa<LoadInst>(TheUser) ||
isa<SelectInst>(TheUser) || isa<PHINode>(TheUser) || // TODO: should these be removed from this list?
isa<StoreInst>(TheUser) || isa<PtrToIntInst>(TheUser) ||
isa<ICmpInst>(TheUser) || isa<InsertElementInst>(TheUser)|| // ICmpEQ/ICmpNE can be used with ptr types
isa<ICmpInst>(TheUser) || // ICmpEQ/ICmpNE can be used with ptr types
isa<AtomicCmpXchgInst>(TheUser) || isa<AtomicRMWInst>(TheUser))
continue;
if (isa<GetElementPtrInst>(TheUser) || isa<BitCastInst>(TheUser) || isa<AddrSpaceCastInst>(TheUser)) {
Expand Down
14 changes: 0 additions & 14 deletions test/llvmpasses/late-lower-gc.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,20 +226,6 @@ define void @decayar([2 x {} addrspace(10)* addrspace(11)*] %ar) {
; OPAQUE: %r = call i32 @callee_root(ptr addrspace(10) %l0, ptr addrspace(10) %l1)
; OPAQUE: call void @julia.pop_gc_frame(ptr %gcframe)

define swiftcc ptr addrspace(10) @insert_element(ptr swiftself %0) {
; CHECK-LABEL: @insert_element
%2 = alloca [10 x i64], i32 1, align 8
; CHECK: %gcframe = call ptr @julia.new_gc_frame(i32 10)
; CHECK: [[gc_slot_addr_:%.*]] = call ptr @julia.get_gc_frame_slot(ptr %gcframe, i32 0)
; CHECK: call void @julia.push_gc_frame(ptr %gcframe, i32 10)
call void null(ptr sret([2 x [5 x ptr addrspace(10)]]) %2, ptr null, ptr addrspace(11) null, ptr null)
%4 = insertelement <4 x ptr> zeroinitializer, ptr %2, i32 0
; CHECK: [[gc_slot_addr_:%.*]] = insertelement <4 x ptr> zeroinitializer, ptr [[gc_slot_addr_:%.*]], i32 0
; CHECK: call void @julia.pop_gc_frame(ptr %gcframe)
ret ptr addrspace(10) null
}


!0 = !{i64 0, i64 23}
!1 = !{!1}
!2 = !{!7} ; scope list
Expand Down