LibGit2: Update to 1.9.1 #58731
LibGit2: Update to 1.9.1 #58731
Conversation
giordano
added
building
There was a problem hiding this comment.
Ah, right, zlib and pcre2 must be specified as dependencies here, and loaded in jll package
There was a problem hiding this comment.
What about JLLWrappers? Should that also be listed as dependency?
There was a problem hiding this comment.
And what about CompilerSupportLibraries_jll? Can that dependency be removed?
https://github.com/JuliaBinaryWrappers/LibGit2_jll.jl/blob/main/Project.toml
There was a problem hiding this comment.
What about JLLWrappers? Should that also be listed as dependency?
That's not an stdlib, so no.
And what about
CompilerSupportLibraries_jll? Can that dependency be removed?https://github.com/JuliaBinaryWrappers/LibGit2_jll.jl/blob/main/Project.toml
It was added by @IanButterworth in #58560.
There was a problem hiding this comment.
It was added because libgcc_s seems to be needed on windows.
The good thing is tests should catch what's needed or unnecessary here.
This comment was marked as resolved.
This comment was marked as resolved.
|
@giordano @IanButterworth Please retrigger the build, there was a spurious failure. |
|
I think you need to update all manifests anyway |
|
This fails because there is a test using |
No description provided.