[NFC] codegen: Move target ABI calculation into jl_jit_abi_converter
#58718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Jun 12, 2025
topolarity
force-pushed
the
ct/jl_jit_abi_converter
branch
2 times, most recently
from
2081695 to
18c74a5
Compare
This relieves the caller of the responsibility to peek into the CodeInstance and pull out all of the correct bits to determine the appropriate callee ABI and makes the API more directly reflect the operation here, which is approximately "Give me a specptr with ABI `abi` that invokes CodeInstance `codeinst`"
topolarity
force-pushed
the
ct/jl_jit_abi_converter
branch
from
18c74a5 to
d7bd27a
Compare
nilesh646
pushed a commit
to nilesh646/julia
that referenced
this pull request
Jun 17, 2025
JuliaLang#58718) Makes the API more directly reflect the operation here, which is essentially "Give me a specptr with ABI `abi` that invokes CodeInstance `codeinst`" This relieves the caller of the responsibility to peek into the CodeInstance and pull out all of the correct bits to determine the appropriate callee ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the API more directly reflect the operation here, which is essentially "Give me a specptr with ABI
abithat invokes CodeInstancecodeinst"This relieves the caller of the responsibility to peek into the CodeInstance and pull out all of the correct bits to determine the appropriate callee ABI.