Skip to content

GC Always Full Flag #58713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

GC Always Full Flag #58713

merged 1 commit into from
Jun 12, 2025

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Jun 11, 2025

This used to be an environment variable (JULIA_GC_NO_GENERATIONAL) that could only be enabled if Julia was built with WITH_GC_DEBUG_ENV.

People benchmarking GC may want to disable generational behavior in non-debug builds as well.

This PR introduces gc-sweep-always-full as a hidden command-line-option.

It also moves the docstrings for --hard-heap-limit and --heap-target-increment into opts_hidden, as it should have been done in the original PR.

@d-netto d-netto requested a review from gbaraldi June 11, 2025 19:06
@d-netto d-netto added the GC Garbage collector label Jun 11, 2025
@d-netto d-netto force-pushed the dcn-gc-always-full branch 3 times, most recently from c4c5156 to 222d997 Compare June 11, 2025 19:31
@d-netto d-netto force-pushed the dcn-gc-always-full branch 2 times, most recently from 4bc8573 to 98a45cf Compare June 12, 2025 01:22
@gitboy16
Copy link
Contributor

Just a formatting comment, in the file jloptions.c , would it be possible to align the command line option to 100 characters max per line as I have done it in the past.
Also could you re-align the option and description for the line "--heap-target-increment ....etc"
Thank you

@d-netto d-netto force-pushed the dcn-gc-always-full branch 3 times, most recently from b00c517 to e21dd7c Compare June 12, 2025 14:28
@d-netto d-netto force-pushed the dcn-gc-always-full branch from e21dd7c to eaebd9f Compare June 12, 2025 17:09
@d-netto d-netto added the merge me PR is reviewed. Merge when all tests are passing label Jun 12, 2025
@d-netto d-netto merged commit 468c057 into master Jun 12, 2025
5 of 8 checks passed
@d-netto d-netto deleted the dcn-gc-always-full branch June 12, 2025 21:44
@d-netto d-netto removed the merge me PR is reviewed. Merge when all tests are passing label Jun 12, 2025
nilesh646 pushed a commit to nilesh646/julia that referenced this pull request Jun 17, 2025
This used to be an environment variable (`JULIA_GC_NO_GENERATIONAL`)
that could only be enabled if Julia was built with `WITH_GC_DEBUG_ENV`.

People benchmarking GC may want to disable generational behavior in
non-debug builds as well.

This PR introduces `gc-sweep-always-full` as a hidden
command-line-option.

It also moves the docstrings for `--hard-heap-limit` and
`--heap-target-increment` into `opts_hidden`, as it should have been
done in the original PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants