expand the IteratorSize(::Type{Char}) method to cover AbstractChar
#58524
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
strings
nsajko
commented
May 25, 2025
The narrow scope of the method seems like a mistake:
* The immediately surrounding lines of code all use `AbstractChar`,
not `Char`.
* `ndims` already returns `0` for new `AbstractChar` subtypes, so it
seems like it would be more consistent for `IteratorSize` to return
`HasShape{0}()` instead of the default, `Base.HasLength()`.
* Broadcasting already treats `AbstractChar` as zero-dimensional, since
PR JuliaLang#41073.
Historic references:
* PR JuliaLang#29819 added the `IteratorSize(::Type{Char})` method. Not sure
why was the method restricted to `Char` instead of to all subtypes
of `AbstractChar`.
nsajko
force-pushed
the
AbstractChar_IteratorSize
branch
from
e483925 to
349d133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The narrow scope of the method seems like a mistake:
The immediately surrounding lines of code all use
AbstractChar, notChar.ndimsalready returns0for newAbstractCharsubtypes, so it seems like it would be more consistent forIteratorSizeto returnHasShape{0}()instead of the default,Base.HasLength().Broadcasting already treats
AbstractCharas zero-dimensional, since PR fix char-broadcast PR to work with AbstractChar #41073.Historic references:
IteratorSize(::Type{Char})method. Not sure why was the method restricted toCharinstead of to all subtypes ofAbstractChar.