Use dwarf for symbol lookup if dladdr fails before doing linear search. #58359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add dwarf info to jlcall wrappers
|
master @btime stacktrace()
91.244 ms (240 allocations: 21.30 KiB)PR @btime stacktrace()
177.255 μs (243 allocations: 21.35 KiB) |
JeffBezanson
reviewed
May 9, 2025
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
58 tasks
|
Bump, anything left to do here? |
|
I need to take another stab at this, This is segfaulting |
|
When writing a small jitdump analyzer I noticed that we are not emitting debuginfo for the API function which may explain why With this PR we are emitting matching debug info for all entries in a short jitdump. |
This was referenced Sep 15, 2025
This was referenced Sep 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add dwarf info to jlcall wrappers
This isn't the full refactor this code deserves but uses dwarf lookups before the bad linear search that #58355 is removing