[deps] enable zstd support #58344
Merged
[deps] enable zstd support #58344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
the
external dependencies
vtjnash
force-pushed
the
jn/zstd
branch
2 times, most recently
from
52e87ac to
1c8eb09
Compare
|
Arg, all of that build effort and the llvm Findzstd script is buggy, producing incorrect results if used with (!MSVC && WIN32) |
giordano
reviewed
May 14, 2025
vtjnash
force-pushed
the
jn/zstd
branch
4 times, most recently
from
3f2403b to
a90046f
Compare
|
i686-w64-mingw32 is running into the same clang ABI miscompiles as we've encountered before. I guess we got lucky before that zlib didn't smash anything too valuable, while zstd does The simplest thing to do may be vendor our own copy of the bad code, until the clang compiler stops miscompiling sret stuff https://llvm.org/doxygen/Compression_8cpp_source.html#l00151 |
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Notably: delete lib/julia/*-o.a files that should not get installed
This works around clang ABI bugs on win32 with Error sret return.
|
Can we disable this on 32 bit windows instead? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on JuliaPackaging/Yggdrasil#11183 to update the LLVM shards also