bpart: Fix a hang in a particular corner case #58271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `jl_get_binding_partition_with_hint` version of the bpart lookup did not properly set the `max_world` of the gap, leaving it at `~(size_t)0`. Having a `gap` with that `max_world`, but with `gap.replace` set is inconsistent and ended up causing an integer overflow downstream in the computation of `expected_prev_min_world`, which looked like a concurrent modification causing an infinite retry.
vtjnash
reviewed
May 1, 2025
| ## The sequence of events is critical here. | ||
| A58257.get! # Creates binding partition in A, N+1:∞ | ||
| A58257.B58257.get! # Creates binding partition in A.B, N+1:∞ | ||
| Base.invoke_in_world(UInt(38678), getglobal, A58257, :get!) # Expands binding partition in A through <N |
There was a problem hiding this comment.
Why are you using random numbers as worlds? This will break very badly someday...
There was a problem hiding this comment.
Was supposed to be captured earlier, just forgot to commit the change. will fix.
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
The `jl_get_binding_partition_with_hint` version of the bpart lookup did not properly set the `max_world` of the gap, leaving it at `~(size_t)0`. Having a `gap` with that `max_world`, but with `gap.replace` set is inconsistent and ended up causing an integer overflow downstream in the computation of `expected_prev_min_world`, which looked like a concurrent modification causing an infinite retry. Fixes JuliaLang#58257
53 tasks
KristofferC
pushed a commit
that referenced
this pull request
May 5, 2025
The `jl_get_binding_partition_with_hint` version of the bpart lookup did not properly set the `max_world` of the gap, leaving it at `~(size_t)0`. Having a `gap` with that `max_world`, but with `gap.replace` set is inconsistent and ended up causing an integer overflow downstream in the computation of `expected_prev_min_world`, which looked like a concurrent modification causing an infinite retry. Fixes #58257 (cherry picked from commit fc8e6e7)
charleskawczynski
pushed a commit
to charleskawczynski/julia
that referenced
this pull request
May 12, 2025
The `jl_get_binding_partition_with_hint` version of the bpart lookup did not properly set the `max_world` of the gap, leaving it at `~(size_t)0`. Having a `gap` with that `max_world`, but with `gap.replace` set is inconsistent and ended up causing an integer overflow downstream in the computation of `expected_prev_min_world`, which looked like a concurrent modification causing an infinite retry. Fixes JuliaLang#58257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
jl_get_binding_partition_with_hintversion of the bpart lookup did not properly set themax_worldof the gap, leaving it at~(size_t)0. Having agapwith thatmax_world, but withgap.replaceset is inconsistent and ended up causing an integer overflow downstream in the computation ofexpected_prev_min_world, which looked like a concurrent modification causing an infinite retry. Fixes #58257