-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fix error hint for missing(1)
#58250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ```julia-repl julia> missing(1) ERROR: MethodError: objects of type Missing are not callable. In case you did not try calling it explicitly, check if a Missing has been passed as an argument to a method that expects a callable instead. The object of type `Missing` exists, but no method is defined for this combination of argument types when trying to treat it as a callable object.┌ Error: Hint-handler nonsetable_type_hint_handler for MethodError in Base caused an error │ exception = │ 1-element ExceptionStack: │ TypeError: non-boolean (Missing) used in boolean context │ Stacktrace: │ [1] nonsetable_type_hint_handler(io::Any, ex::Any, arg_types::Any, kwargs::Any) │ @ Base ./errorshow.jl:1054 │ [2] show_error_hints(::IOContext{Base.TTY}, ::MethodError, ::Vector{Any}, ::Vararg{Vector{Any}}) │ @ Base.Experimental ./experimental.jl:322 │ [3] showerror(io::IO, ex::MethodError) │ @ Base ./errorshow.jl:374 │ [4] showerror(io::IOContext{Base.TTY}, ex::MethodError, bt::Vector{Base.StackTraces.StackFrame}; backtrace::Bool) │ @ Base ./errorshow.jl:106 │ [5] show_exception_stack(io::IOContext{Base.TTY}, stack::Base.ExceptionStack) │ @ Base ./errorshow.jl:1017 │ [6] display_error(io::IOContext{Base.TTY}, stack::Base.ExceptionStack) │ @ Base ./client.jl:117 │ [7] repl_display_error(errio::IO, errval::Any) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:565 │ [8] print_response(errio::IO, response::Any, backend::Union{Nothing, REPL.REPLBackendRef}, show_value::Bool, have_color::Bool, specialdisplay::Union{Nothing, AbstractDisplay}) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:582 │ [9] (::REPL.var"#print_response##0#print_response##1"{REPL.LineEditREPL, Pair{Any, Bool}, Bool, Bool})(io::Any) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:556 │ [10] with_repl_linfo(f::Any, repl::REPL.LineEditREPL) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:829 │ [11] print_response(repl::REPL.AbstractREPL, response::Any, show_value::Bool, have_color::Bool) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:554 │ [12] (::REPL.var"#do_respond#73"{Bool, Bool, REPL.var"#setup_interface##12#setup_interface##13"{REPL.LineEditREPL, REPL.REPLHistoryProvider}, REPL.LineEditREPL, REPL.LineEdit.Prompt})(s::REPL.LineEdit.MIState, buf::Any, ok::Bool) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:1186 │ [13] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState) │ @ REPL.LineEdit ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/LineEdit.jl:2852 │ [14] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:1657 │ [15] (::REPL.var"#61#62"{REPL.LineEditREPL, REPL.REPLBackendRef})() │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:648 └ @ Base.Experimental experimental.jl:325 Stacktrace: [1] top-level scope @ REPL[1]:1 ``` After: ```julia-repl julia> missing(1) ERROR: MethodError: objects of type Missing are not callable. In case you did not try calling it explicitly, check if a Missing has been passed as an argument to a method that expects a callable instead. The object of type `Missing` exists, but no method is defined for this combination of argument types when trying to treat it as a callable object. Stacktrace: [1] top-level scope @ REPL[3]:1 ``` I do not know how to test this; error hint handlers are explicitly purged before running tests and I don't see any existing tests.
IanButterworth
approved these changes
May 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I took the liberty of pushing a test. Note that the error hints are registered here
Line 12 in 0901170
Base.Experimental.register_error_hint(Base.nonsetable_type_hint_handler, MethodError) |
charleskawczynski
pushed a commit
to charleskawczynski/julia
that referenced
this pull request
May 12, 2025
Before: ```julia-repl julia> missing(1) ERROR: MethodError: objects of type Missing are not callable. In case you did not try calling it explicitly, check if a Missing has been passed as an argument to a method that expects a callable instead. The object of type `Missing` exists, but no method is defined for this combination of argument types when trying to treat it as a callable object.┌ Error: Hint-handler nonsetable_type_hint_handler for MethodError in Base caused an error │ exception = │ 1-element ExceptionStack: │ TypeError: non-boolean (Missing) used in boolean context │ Stacktrace: │ [1] nonsetable_type_hint_handler(io::Any, ex::Any, arg_types::Any, kwargs::Any) │ @ Base ./errorshow.jl:1054 │ [2] show_error_hints(::IOContext{Base.TTY}, ::MethodError, ::Vector{Any}, ::Vararg{Vector{Any}}) │ @ Base.Experimental ./experimental.jl:322 │ [3] showerror(io::IO, ex::MethodError) │ @ Base ./errorshow.jl:374 │ [4] showerror(io::IOContext{Base.TTY}, ex::MethodError, bt::Vector{Base.StackTraces.StackFrame}; backtrace::Bool) │ @ Base ./errorshow.jl:106 │ [5] show_exception_stack(io::IOContext{Base.TTY}, stack::Base.ExceptionStack) │ @ Base ./errorshow.jl:1017 │ [6] display_error(io::IOContext{Base.TTY}, stack::Base.ExceptionStack) │ @ Base ./client.jl:117 │ [7] repl_display_error(errio::IO, errval::Any) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:565 │ [8] print_response(errio::IO, response::Any, backend::Union{Nothing, REPL.REPLBackendRef}, show_value::Bool, have_color::Bool, specialdisplay::Union{Nothing, AbstractDisplay}) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:582 │ [9] (::REPL.var"#print_response##0#print_response#JuliaLang#1"{REPL.LineEditREPL, Pair{Any, Bool}, Bool, Bool})(io::Any) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:556 │ [10] with_repl_linfo(f::Any, repl::REPL.LineEditREPL) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:829 │ [11] print_response(repl::REPL.AbstractREPL, response::Any, show_value::Bool, have_color::Bool) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:554 │ [12] (::REPL.var"#do_respond#73"{Bool, Bool, REPL.var"#setup_interface#JuliaLang#12#setup_interface#JuliaLang#13"{REPL.LineEditREPL, REPL.REPLHistoryProvider}, REPL.LineEditREPL, REPL.LineEdit.Prompt})(s::REPL.LineEdit.MIState, buf::Any, ok::Bool) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:1186 │ [13] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState) │ @ REPL.LineEdit ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/LineEdit.jl:2852 │ [14] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef) │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:1657 │ [15] (::REPL.var"JuliaLang#61#62"{REPL.LineEditREPL, REPL.REPLBackendRef})() │ @ REPL ~/.julia/juliaup/julia-nightly/share/julia/stdlib/v1.13/REPL/src/REPL.jl:648 └ @ Base.Experimental experimental.jl:325 Stacktrace: [1] top-level scope @ REPL[1]:1 ``` After: ```julia-repl julia> missing(1) ERROR: MethodError: objects of type Missing are not callable. In case you did not try calling it explicitly, check if a Missing has been passed as an argument to a method that expects a callable instead. The object of type `Missing` exists, but no method is defined for this combination of argument types when trying to treat it as a callable object. Stacktrace: [1] top-level scope @ REPL[3]:1 ``` --------- Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
error messages
Better, more actionable error messages
missing data
Base.missing and related functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
I do not know how to test this; error hint handlers are explicitly purged before running tests and I don't see any existing tests.