inference: prevent nested slot wrappers in abstract_call_builtin #58249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `Core.isdefined` handling in `abstract_call_builtin` to avoid creating nested slot wrappers. This bug only affected interpreters using the `MustAliasesLattice`, and prevented JET’s test suite from passing on the v1.13 nightly. With this change, JET tests now pass successfully. Audited other `Conditional` creation sites and confirmed that each calls `widen_slot_wrapper([then|else]type)`, so no similar issues were found.
aviatesk
force-pushed
the
avi/fix-nested-slot-wrappers
branch
from
6acf966 to
21f9e84
Compare
charleskawczynski
pushed a commit
to charleskawczynski/julia
that referenced
this pull request
May 12, 2025
aviatesk
added a commit
that referenced
this pull request
May 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
Core.isdefinedhandling inabstract_call_builtinto avoid creating nested slot wrappers. This bug only affected interpreters using theMustAliasesLattice, and prevented JET’s test suite from passing on the v1.13 nightly.With this change, JET tests now pass successfully.
Audited other
Conditionalcreation sites and confirmed that each callswiden_slot_wrapper([then|else]type), so no similar issues were found.