Align :method Expr return value between interpreter and codegen
#58076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interpreter/inference think the 3-argument `:method` Expr returns `nothing`. Codegen thinks it returns the new method. I think the latter makes more sense, because it lets us write explicit syntax-level dependency links between method definitions and constants (used e.g. for external abstract interpreters), which is something that Revise may need in the future. Adjust the interpreter/inference to properly return the method.
|
I played with this a bit more and it's actually very hard to get at the return value of that |
|
Per discussion with @JeffBezanson - this change is fine, but should insert explicit |
Keno
force-pushed
the
kf/methodretmethod
branch
from
b986db7 to
d448a7a
Compare
serenity4
added a commit
to serenity4/JuliaInterpreter.jl
that referenced
this pull request
Apr 15, 2025
aviatesk
added a commit
to JuliaDebug/JuliaInterpreter.jl
that referenced
this pull request
Apr 21, 2025
* Support evaluation of overlayed methods * Add comment * Bump version * Support more expression types defining the external method table * Attempt a few fixes * Fix 1.12/nightly failures that were present before this PR * Adjust to JuliaLang/julia#58076 * `jl_method_def` actually returned a `Method` already * Export `extract_method_table`, add option to disallow `eval` * Quickly try a nightly fix * Remove unnecessary dependency on Tensors for testing The test that used it doesn't actually need it to test what was intended * Wrap evaluation in try/catch * Use isdefinedglobal * Adjust broken test to have it throw consistently Otherwise, it would fail at the first evaluation and succeed on subsequent ones. * Update comment * Replace `Core.eval` with `getglobal` * Update src/interpret.jl Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com> --------- Co-authored-by: Cédric Belmant <cedric.belmant@juliahub.com> Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
…liaLang#58076) Interpreter/inference think the 3-argument `:method` Expr returns `nothing`. Codegen thinks it returns the new method. I think the latter makes more sense, because it lets us write explicit syntax-level dependency links between method definitions and constants (used e.g. for external abstract interpreters), which is something that Revise may need in the future. Adjust the interpreter/inference to properly return the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpreter/inference think the 3-argument
:methodExpr returnsnothing. Codegen thinks it returns the new method. I think the latter makes more sense, because it lets us write explicit syntax-level dependency links between method definitions and constants (used e.g. for external abstract interpreters), which is something that Revise may need in the future. Adjust the interpreter/inference to properly return the method.