inference: model Core._svec_ref
#57973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Core._svec_ref` was added in #45062, but its rt, effects and exct have not been properly modeled in the compiler. This usually isn't a problem because `Core._svec_ref` gets optimized away by the `lift_svec_ref!` pass during optimization. However, external abstract interpreters like JET, which don't run these optimizations, can have type inference issues because of this. This commit adds the correct handling. Also, `Base.ismutationfree(Core.Simplevector)` was incorrectly returning `true`. This commit fixes that too.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Apr 1, 2025
This test case doesn't pass until JuliaLang/julia#57973 gets backported.
Keno
approved these changes
Apr 1, 2025
aviatesk
added a commit
that referenced
this pull request
Apr 2, 2025
51 tasks
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core._svec_refwas added in #45062, but its rt, effects and exct have not been properly modeled in the compiler.This usually isn't a problem because
Core._svec_refgets optimized away by thelift_svec_ref!pass during optimization. However, external abstract interpreters like JET, which don't run these optimizations, can have type inference issues because of this. This commit adds the correct handling.Also,
Base.ismutationfree(Core.Simplevector)was incorrectly returningtrue. This commit fixes that too.