inference: add internal SOURCE_MODE_GET_SOURCE mode #57878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
compiler:inference
vtjnash
force-pushed
the
jn/inference-SOURCE_MODE_GET_SOURCE
branch
from
66d49b0 to
f451329
Compare
We were previously using typeinf_code for this, but that has slightly different semantics for recursion detection and handling of some edge cases related to caching (e.g. seen in #57634). Overall, we would like to avoid those sorts of spurious differences in compilation. Instead (re)introduce a `source_mode` called `SOURCE_MODE_GET_SOURCE` which can be used internally (requires a NativeInterpreter) here to avoid needing to duplicate the existing `typeinf_ext` code to implement this use case. While we are at it, also remove the code duplication for `typeinf_type`.
vtjnash
force-pushed
the
jn/inference-SOURCE_MODE_GET_SOURCE
branch
from
f451329 to
14bbb4a
Compare
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
Helps avoids some code duplication and divergence of inference behaviors in some edge cases, also slightly more correct caching in some edge cases. (cherry picked from commit e7ff95d)
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
Helps avoids some code duplication and divergence of inference behaviors in some edge cases, also slightly more correct caching in some edge cases. (cherry picked from commit e7ff95d)
51 tasks
DilumAluthge
removed
the
merge me
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
Helps avoids some code duplication and divergence of inference behaviors in some edge cases, also slightly more correct caching in some edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps avoids some code duplication and divergence of inference behaviors in some edge cases