-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
unify prod(::Tuple{Vararg{Int}}) with a single method
#57628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify prod(::Tuple{Vararg{Int}}) with a single method
#57628
Conversation
One less method.
This is required to avoid introducing a name / binding in the Module without a corresponding definition. Resolves #57808
|
This has caused quite a few performance regressions in the array indexing benchmarks in BaseBenchmarks. See for example the following regressions taken from https://github.com/JuliaCI/NanosoldierReports/blob/master/benchmark/by_date/2025-03/21/report.md and https://tealquaternion.camdvr.org/compare.html?start=9294132415cfdf2198b64d03f0fd58f8a4d3a258&end=b8dc57e59db11658cb57424e4e12773f572a6517&stat=min-wall-time&name=array.index
|
…aLang#57628)" This reverts commit 3d62893. See JuliaLang#57628 (comment) for array indexing regressions
|
Observations regarding the regression:
|
…)" (#57894) This reverts commit 3d62893. See #57628 (comment) for array indexing regressions
One less method.