Base: bootstrap: eliminate Array-specific length methods
#57627
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three methods of `length` are deleted. Made possible by moving the following methods to earlier within the bootstrapping: * `size(a::Array)` * `length(t::AbstractArray)` Improves abstract return type inference of `f(x::Array) = length(a)`, presumably because the method count is now low enough for the world-splitting optimization to kick in.
|
|
|
Absolutely, this causes tons of invalidations, which is why I marked the PR as draft. Perhaps it'd make sense to set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three methods of
lengthare deleted.Made possible by moving the following methods to earlier within the bootstrapping:
size(a::Array)length(t::AbstractArray)Improves abstract return type inference of
f(x::Array) = length(a), presumably because the method count is now low enough for the world-splitting optimization to kick in.