Don't delete inferred code from external interpreters #57224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Jan 31, 2025
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
vchuravy
approved these changes
Feb 1, 2025
giordano
pushed a commit
that referenced
this pull request
Feb 1, 2025
We were deleting code from external abstract interpreters since bdf8219. Fixes JuliaGPU/CUDA.jl#2637. Not sure how to write tests for this :( --------- Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> (cherry picked from commit 832f084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were deleting code from external abstract interpreters since bdf8219.
Fixes JuliaGPU/CUDA.jl#2637. Not sure how to write tests for this :(