broadcast: align ndims implementation with intent behind code
#56999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
arrays
nsajko
commented
Jan 8, 2025
nsajko
force-pushed
the
ndims_broadcasted
branch
from
f179208 to
f53d3a2
Compare
nsajko
added
backport 1.10
ararslan
reviewed
Jan 9, 2025
jishnub
reviewed
Jan 9, 2025
nsajko
force-pushed
the
ndims_broadcasted
branch
from
f5afe58 to
5f43d7d
Compare
nsajko
commented
Jan 9, 2025
The `N<:Integer` constraint was nonsensical, given that `(N === Any) || (N isa Int)`. N5N3 noticed this back in 2022: JuliaLang#44061 (comment) Follow up on JuliaLang#44061. Also xref JuliaLang#45477.
nsajko
force-pushed
the
ndims_broadcasted
branch
from
827581d to
e5b8d16
Compare
KristofferC
pushed a commit
that referenced
this pull request
Jan 13, 2025
The `N<:Integer` constraint was nonsensical, given that `(N === Any) || (N isa Int)`. N5N3 noticed this back in 2022: #44061 (comment) Follow up on #44061. Also xref #45477. (cherry picked from commit d3964b6)
KristofferC
removed
the
backport 1.11
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Feb 9, 2025
…aLang#56999) The `N<:Integer` constraint was nonsensical, given that `(N === Any) || (N isa Int)`. N5N3 noticed this back in 2022: JuliaLang#44061 (comment) Follow up on JuliaLang#44061. Also xref JuliaLang#45477. (cherry picked from commit d3964b6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
N<:Integerconstraint was nonsensical, given that(N === Any) || (N isa Int). N5N3 noticed this back in 2022: #44061 (comment)Follow up on #44061. Also xref #45477.