Support sort(keys(::Dict)) and sort(values(::Dict))
#56978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilithHafner
added
iteration
nsajko
reviewed
Jan 9, 2025
Co-authored-by: Neven Sajko <4944410+nsajko@users.noreply.github.com>
nsajko
approved these changes
Jan 10, 2025
Including updating the version in the title
LilithHafner
added a commit
that referenced
this pull request
Mar 26, 2025
In cases where a function is documented as
```
function(arg::ArgT, arg2::Arg2T) -> RetT
...
```
I either switched ` -> ` to `::` or switched `RetT` to `ret_name::RetT`.
From the recommendation and justification from @nsajko here:
#56978 (comment) and
applied throughout the repo.
As documented here #57583
Also includes some minor changes to touched lines (e.g. removing annotations that are just clutter)
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
In cases where a function is documented as
```
function(arg::ArgT, arg2::Arg2T) -> RetT
...
```
I either switched ` -> ` to `::` or switched `RetT` to `ret_name::RetT`.
From the recommendation and justification from @nsajko here:
JuliaLang#56978 (comment) and
applied throughout the repo.
As documented here JuliaLang#57583
Also includes some minor changes to touched lines (e.g. removing annotations that are just clutter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the sorting iterables saga:
#38328
#46104
#51977
#52010
#54494