CodeInstance: remove relocatability field #56975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
approved these changes
Jan 8, 2025
aviatesk
previously requested changes
Jan 8, 2025
Member
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
The CI failure looks real, which looks like we are marking atomic fields incorrectly.
This field lost its meaning awhile back and is better tracked only as part of the compressed CodeInfo instead of trying to accurately copy and update this field.
vtjnash
force-pushed
the
jn/relocatibility-field
branch
from
55cbd3d to
d5ff803
Compare
IanButterworth
removed
the
merge me
Member
|
This seems to be the cause of the BigInt slowdown in https://github.com/JuliaCI/NanosoldierReports/blob/master/benchmark/by_date/2025-02/07/report.md |
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
This field lost its meaning awhile back and is better tracked only as part of the compressed CodeInfo instead of trying to accurately copy and update this field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field lost its meaning awhile back and is better tracked only as part of the compressed CodeInfo instead of trying to accurately copy and update this field.