-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
add shuffle(::NTuple)
to Random
#56906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nsajko
wants to merge
25
commits into
JuliaLang:master
Choose a base branch
from
nsajko:shuffle_ntuple
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7936a9f
add `shuffle(::NTuple)` to `Random`
nsajko f3fb9f9
rely on `shuffle!` and on escape analysis instead of on recursion
nsajko dc162c3
bugfix: use provided pseudorandom generator
nsajko 2eee6e6
simplify using `randperm!` as per rfourqet
nsajko 8a8efff
delete unnecessary branch
nsajko fcec466
reindent
nsajko 9e9c1a5
add news
nsajko ed3e09a
update doc string, and apply it to the function instead of to a method
nsajko 5b50ae3
use narrower type when possible as per rfourqet
nsajko 90f1d2d
de-hardcode `typemax(UInt8)`
nsajko 6e80b0d
safer
nsajko 18ededb
use `shuffle!` instead of `randperm!` again
nsajko c6c3997
relax one-arg method
nsajko 4ab6f86
simpler dispatch constraint
nsajko d7191ef
delete now unnecessary method
nsajko 8f3800f
delete extraneous newline
nsajko ba162dc
omit no alloc test set
nsajko 912ec6c
fix dispatch constraint: restrict to `NTuple`
nsajko 35feb2d
add compat annotation to doc string
nsajko bed23af
adjust "not identity at least once" test
nsajko 9944d1c
expand comment
nsajko 6ebd824
simplify syntax, less `let`, etc
nsajko d1ea278
use `randperm!` again, as it supports `Memory` now
nsajko f9dd73d
restrict the one-arg method from `Tuple` to `NTuple`
nsajko 157ad7a
Merge branch 'master' into shuffle_ntuple
nsajko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for which sizes of tuples does this
Ind
help? is there a cutoff?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there's a cutoff. The transformation of
Memory
heap allocations to stack allocations currently only works forMemory
with small statically-known size. See PR #56847.