better implementations for unionlen/uniontypes
#55561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unify the dispatch targets - removed unnecessary `_uniontypes(::MustAlias)` method
vtjnash
approved these changes
Aug 22, 2024
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
I feel like inlining should have generated the same code either way, but LGTM
KristofferC
pushed a commit
that referenced
this pull request
Sep 12, 2024
- unify the dispatch targets - removed unnecessary `_uniontypes(::MustAlias)` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_uniontypes(::MustAlias)method