Revert "better type inference for several functions taking NTuple args"
#55375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
performance
nsajko
reviewed
Aug 6, 2024
| ntuple(Val{N}()) do i | ||
| t[end+1-i] | ||
| end::NTuple | ||
| end |
There was a problem hiding this comment.
Could you leave this part in? It's just an unconditional type assert, so it shouldn't cause any harm.
There was a problem hiding this comment.
Let's get back to a known good state and we can re-add this if it is shown with the benchmarks the regressed to be ok.
KristofferC
deleted the
revert-55124-better_return_type_inference_for_tail_front_circshift_reverse
branch
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Aug 6, 2024
Just adds an `::NTuple` type assertion to the result. Before the return type of `reverse(::NTuple)` inferred as `Tuple`, now it's more precise, inferring as `NTuple`. This is a partial reland of JuliaLang#55124 and partial revert of JuliaLang#55375. Updates JuliaLang#54495
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
…rgs" (JuliaLang#55375) Reverts JuliaLang#55124 as this turns out to hurt performance quite a bit Closes JuliaLang#55374
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Feb 5, 2025
Just adds an `::NTuple` type assertion to the result. Before the return type of `reverse(::NTuple)` inferred as `Tuple`, now it's more precise, inferring as `NTuple`. This is a partial reland of JuliaLang#55124 and partial revert of JuliaLang#55375. Updates JuliaLang#54495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #55124 as this turns out to hurt performance quite a bit
Closes #55374