Skip to content

Document Task(f, n) API #55184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2024
Merged

Document Task(f, n) API #55184

merged 2 commits into from
Jul 25, 2024

Conversation

@MilesCranmer
Copy link
Member

@MilesCranmer MilesCranmer commented Jul 20, 2024

Fixes #55005 and helps work around issues discussed in #54998.

@MilesCranmer MilesCranmer mentioned this pull request Jul 20, 2024
Merged
@nsajko nsajko added the docs This change adds or pertains to documentation label Jul 20, 2024
This was referenced Jul 21, 2024
Open
Open
@fingolfin fingolfin requested a review from vtjnash July 25, 2024 11:45
fingolfin
fingolfin approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. But would be nice if e.g. @vtjnash had a look just to make sure there aren't deeper reasons for not making this public that I am unaware of.

vtjnash
vtjnash approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting it

@vtjnash vtjnash merged commit 8e5ca0b into JuliaLang:master Jul 25, 2024
@MilesCranmer MilesCranmer deleted the task-docs branch July 25, 2024 22:36
lazarusA pushed a commit to lazarusA/julia that referenced this pull request Aug 17, 2024
@MilesCranmer @lazarusA
Document Task(f, n) API (JuliaLang#55184)
71387bc 
Fixes JuliaLang#55005 and helps work
around issues discussed in
JuliaLang#54998.
@nsajko nsajko mentioned this pull request Apr 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fingolfin fingolfin fingolfin approved these changes

@vtjnash vtjnash vtjnash approved these changes

Assignees

No one assigned

Labels

docs This change adds or pertains to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

document the optional argument of the Task constructor

4 participants

@MilesCranmer @fingolfin @vtjnash @nsajko