Skip to content

LinearAlgebra: Do not specialize arguments in check_A_mul_B!_sizes #55176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

LinearAlgebra: Do not specialize arguments in check_A_mul_B!_sizes #55176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07ce759
LinearAlgebra: Do not specialize arguments in check_A_mul_B!_sizes
jishnub Jul 19, 2024
a3f49e3
Use sizes in check_A_mul_B!_sizes
jishnub Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions stdlib/LinearAlgebra/src/bidiag.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,10 +541,7 @@ function rmul!(B::Bidiagonal, D::Diagonal)
return B
end

function check_A_mul_B!_sizes(C, A, B)
mA, nA = size(A)
mB, nB = size(B)
mC, nC = size(C)
@noinline function check_A_mul_B!_sizes((mC, nC)::NTuple{2,Integer}, (mA, nA)::NTuple{2,Integer}, (mB, nB)::NTuple{2,Integer})
if mA != mC
throw(DimensionMismatch(lazy"first dimension of A, $mA, and first dimension of output C, $mC, must match"))
elseif nA != mB
Expand Down Expand Up @@ -573,7 +570,7 @@ _mul!(C::AbstractMatrix, A::BiTriSym, B::TriSym, _add::MulAddMul) =
_mul!(C::AbstractMatrix, A::BiTriSym, B::Bidiagonal, _add::MulAddMul) =
_bibimul!(C, A, B, _add)
function _bibimul!(C, A, B, _add)
check_A_mul_B!_sizes(C, A, B)
check_A_mul_B!_sizes(size(C), size(A), size(B))
n = size(A,1)
n <= 3 && return mul!(C, Array(A), Array(B), _add.alpha, _add.beta)
# We use `_rmul_or_fill!` instead of `_modify!` here since using
Expand Down Expand Up @@ -631,7 +628,7 @@ end

function _mul!(C::AbstractMatrix, A::BiTriSym, B::Diagonal, _add::MulAddMul)
require_one_based_indexing(C)
check_A_mul_B!_sizes(C, A, B)
check_A_mul_B!_sizes(size(C), size(A), size(B))
n = size(A,1)
iszero(n) && return C
n <= 3 && return mul!(C, Array(A), Array(B), _add.alpha, _add.beta)
Expand Down Expand Up @@ -697,7 +694,7 @@ end

function _mul!(C::AbstractMatrix, A::AbstractMatrix, B::TriSym, _add::MulAddMul)
require_one_based_indexing(C, A)
check_A_mul_B!_sizes(C, A, B)
check_A_mul_B!_sizes(size(C), size(A), size(B))
iszero(_add.alpha) && return _rmul_or_fill!(C, _add.beta)
n = size(A,1)
m = size(B,2)
Expand Down Expand Up @@ -732,7 +729,7 @@ end

function _mul!(C::AbstractMatrix, A::AbstractMatrix, B::Bidiagonal, _add::MulAddMul)
require_one_based_indexing(C, A)
check_A_mul_B!_sizes(C, A, B)
check_A_mul_B!_sizes(size(C), size(A), size(B))
iszero(_add.alpha) && return _rmul_or_fill!(C, _add.beta)
if size(A, 1) <= 3 || size(B, 2) <= 1
return mul!(C, Array(A), Array(B), _add.alpha, _add.beta)
Expand Down Expand Up @@ -762,7 +759,7 @@ _mul!(C::AbstractMatrix, A::Diagonal, B::TriSym, _add::MulAddMul) =
_dibimul!(C, A, B, _add)
function _dibimul!(C, A, B, _add)
require_one_based_indexing(C)
check_A_mul_B!_sizes(C, A, B)
check_A_mul_B!_sizes(size(C), size(A), size(B))
n = size(A,1)
n <= 3 && return mul!(C, Array(A), Array(B), _add.alpha, _add.beta)
_rmul_or_fill!(C, _add.beta) # see the same use above
Expand Down