Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Base.Fix as general Fix1/Fix2 for partially-applied functions #54653

Merged
merged 83 commits into from
Aug 3, 2024
Merged

Create Base.Fix as general Fix1/Fix2 for partially-applied functions #54653

merged 83 commits into from
Aug 3, 2024

Commits on Jun 2, 2024

  1. Create Base.FixN for complex functional workflows

    @MilesCranmer
    MilesCranmer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    a2b0d84 View commit details
    Browse the repository at this point in the history

  2. add test for chaining FixN together

    @MilesCranmer
    MilesCranmer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    402ed6c View commit details
    Browse the repository at this point in the history

  3. allow varargs inside FixN

    @MilesCranmer
    MilesCranmer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    2c0d91c View commit details
    Browse the repository at this point in the history

  4. remove +0 in FixN

    @MilesCranmer
    MilesCranmer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    b25bb9e View commit details
    Browse the repository at this point in the history

  5. rename to Fix function

    @MilesCranmer
    MilesCranmer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    c4c9b33 View commit details
    Browse the repository at this point in the history

  6. ensure Val constructors always inlined

    @MilesCranmer
    MilesCranmer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    3cb4133 View commit details
    Browse the repository at this point in the history

  7. test for number of arguments edgecase

    @MilesCranmer
    MilesCranmer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    9867242 View commit details
    Browse the repository at this point in the history

  8. fix bound

    @MilesCranmer
    MilesCranmer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    c52779b View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. allow fixing kwargs in Base.Fix as well

    @MilesCranmer
    MilesCranmer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7cf7203 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fixN

    @DilumAluthge
    DilumAluthge authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    325621a View commit details
    Browse the repository at this point in the history

  3. switch to Fix{n} syntax

    @MilesCranmer
    MilesCranmer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e377640 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. back to minimal Fix implementation

    @MilesCranmer
    MilesCranmer committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a2d8605 View commit details
    Browse the repository at this point in the history

  2. clean up docstring with keyword-less version

    @MilesCranmer
    MilesCranmer committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    2491c62 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. allow keywords in Fix and rewrite Fix1/Fix2

    @MilesCranmer
    MilesCranmer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    439c5b6 View commit details
    Browse the repository at this point in the history

  2. prevent keywords from being passed to Fix1/Fix2

    @MilesCranmer
    MilesCranmer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4a0e778 View commit details
    Browse the repository at this point in the history

  3. use nothing instead of Tuple{}

    @MilesCranmer
    MilesCranmer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a473b5e View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. update Fix1/Fix2 docstrings

    @MilesCranmer
    MilesCranmer authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    758bbcc View commit details
    Browse the repository at this point in the history

  2. fix undefined @NamedTuple

    @MilesCranmer
    MilesCranmer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    e2fc740 View commit details
    Browse the repository at this point in the history

  3. constrain K to NamedTuple

    @MilesCranmer
    MilesCranmer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    9aa7c52 View commit details
    Browse the repository at this point in the history

  4. extend docstring for Base.Fix

    @MilesCranmer
    MilesCranmer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b886dd0 View commit details
    Browse the repository at this point in the history

  5. update tests for Base.Fix

    @MilesCranmer
    MilesCranmer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    c32c65a View commit details
    Browse the repository at this point in the history

  6. add Base.Fix to docs

    @MilesCranmer
    MilesCranmer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    866c7c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. add dummy-proofing to Base.Fix{n}

    @MilesCranmer
    MilesCranmer committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    a9674c0 View commit details
    Browse the repository at this point in the history

  2. simplify validation check

    @MilesCranmer
    MilesCranmer committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    1825f76 View commit details
    Browse the repository at this point in the history

  3. unify Fix constructors with Union{F,Type{F}}

    @MilesCranmer
    MilesCranmer committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    5604ffe View commit details
    Browse the repository at this point in the history

  4. improve readability of validation code

    @MilesCranmer
    MilesCranmer committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    74dcfb1 View commit details
    Browse the repository at this point in the history

  5. update tests with allowed behavior

    @MilesCranmer
    MilesCranmer committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    10b8320 View commit details
    Browse the repository at this point in the history

  6. make constructors more readable

    @MilesCranmer
    MilesCranmer committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    73dd2cf View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. tweak docstring

    @MilesCranmer
    MilesCranmer authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    fb8ad78 View commit details
    Browse the repository at this point in the history

  2. tweak docstring

    @MilesCranmer
    MilesCranmer authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    de330be View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Fix syntax takes symbol as parameter

    @MilesCranmer
    MilesCranmer committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    a24f389 View commit details
    Browse the repository at this point in the history

  2. remove redundant Fix1/Fix2 methods

    @MilesCranmer
    MilesCranmer committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1b5ffc1 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. add note about nested Fix

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    6d92c1a View commit details
    Browse the repository at this point in the history

  2. amend Fix validation to not convert to Int64

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    bc053cf View commit details
    Browse the repository at this point in the history

  3. improve Fix readability

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    3c19ecf View commit details
    Browse the repository at this point in the history

  4. rearrange branches in Fix for robust errors

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    3374b8f View commit details
    Browse the repository at this point in the history

  5. rewrite Fix1/Fix2 docstrings to be aliases

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    8d9c690 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
    @MilesCranmer @LilithHafner
    MilesCranmer and LilithHafner authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    9a4926e View commit details
    Browse the repository at this point in the history

  7. single branch for Fix{n::Int}

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    aa08daf View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
    @MilesCranmer @LilithHafner
    MilesCranmer and LilithHafner authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    e541a51 View commit details
    Browse the repository at this point in the history

  9. one-line validations

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    751e964 View commit details
    Browse the repository at this point in the history

  10. remove @inline as not needed

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    669f753 View commit details
    Browse the repository at this point in the history

  11. add Fix to public

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    5694840 View commit details
    Browse the repository at this point in the history

  12. update comments

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    87f5575 View commit details
    Browse the repository at this point in the history

  13. avoid redundant Val

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    79dcd6d View commit details
    Browse the repository at this point in the history

  14. reduce lines of _validate_fix_param

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f3d5c5c View commit details
    Browse the repository at this point in the history

  15. remove old empty Fix test

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c8bc1ab View commit details
    Browse the repository at this point in the history

  16. update Fix tests with latest changes

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    e9c566b View commit details
    Browse the repository at this point in the history

  17. update Fix test with new error message

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    9b1d749 View commit details
    Browse the repository at this point in the history

  18. reduce branches

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    47a49bf View commit details
    Browse the repository at this point in the history

  19. inline _validate_fix_param

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    06aab6f View commit details
    Browse the repository at this point in the history

  20. Merge branch 'master' into fixN

    @MilesCranmer
    MilesCranmer authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    54150eb View commit details
    Browse the repository at this point in the history

  21. Apply suggestions from code review 

    Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
    @MilesCranmer @LilithHafner
    MilesCranmer and LilithHafner authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    6028074 View commit details
    Browse the repository at this point in the history

  22. Update base/operators.jl 

    Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
    @MilesCranmer @LilithHafner
    MilesCranmer and LilithHafner authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f2980d4 View commit details
    Browse the repository at this point in the history

  23. clean up more redundancies in tests

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    5146e1e View commit details
    Browse the repository at this point in the history

  24. clean up more redundancies in tests

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    cec1675 View commit details
    Browse the repository at this point in the history

  25. modify REPL test with new Fix docstring

    @MilesCranmer
    MilesCranmer committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    09ee6ec View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. add special cases for constant propagation

    @MilesCranmer
    MilesCranmer committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    42a1e3e View commit details
    Browse the repository at this point in the history

  2. soften wording of nested Fix note

    @MilesCranmer
    MilesCranmer committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    bd51d2e View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
    @MilesCranmer @LilithHafner
    MilesCranmer and LilithHafner authored Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9d8e9ab View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
Co-authored-by: Alexander Plavin <alexander@plav.in>
    @MilesCranmer @LilithHafner @aplavin
    3 people authored Jul 6, 2024
    Configuration menu
    Copy the full SHA
    717f39b View commit details
    Browse the repository at this point in the history

  2. test for Fix: update tests to new error message; add zero-arg test

    @MilesCranmer
    MilesCranmer committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3f2b116 View commit details
    Browse the repository at this point in the history

  3. grammar in error message

    @MilesCranmer
    MilesCranmer committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    316db38 View commit details
    Browse the repository at this point in the history

  4. more grammar tweaks in error message

    @MilesCranmer
    MilesCranmer committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    04c247c View commit details
    Browse the repository at this point in the history

  5. test multiple kw error message

    @MilesCranmer
    MilesCranmer committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1908c1f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fixN

    @MilesCranmer
    MilesCranmer committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3fbdb91 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Update base/operators.jl 

    Co-authored-by: Neven Sajko <s@purelymail.com>
    @MilesCranmer @nsajko
    MilesCranmer and nsajko authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d514e46 View commit details
    Browse the repository at this point in the history

  2. docs: space out compat statement

    @MilesCranmer
    MilesCranmer authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ded1bfb View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. docs: describe Fix in NEWS

    @MilesCranmer
    MilesCranmer committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    2e9a91c View commit details
    Browse the repository at this point in the history

  2. docs: tweak docstring for Fix

    @MilesCranmer
    MilesCranmer committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    08d774b View commit details
    Browse the repository at this point in the history

  3. docs: formatting docstring for Fix

    @MilesCranmer
    MilesCranmer committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1a107b0 View commit details
    Browse the repository at this point in the history

  4. nitpick docstring grammar

    @MilesCranmer
    MilesCranmer committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6bc91a2 View commit details
    Browse the repository at this point in the history

  5. normalize compat statement to other docstrings

    @MilesCranmer
    MilesCranmer committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3e19e97 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. feat: remove single keyword version of Fix

    @MilesCranmer
    MilesCranmer committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ff197b8 View commit details
    Browse the repository at this point in the history

  2. docs: back to old compat statement

    @MilesCranmer
    MilesCranmer committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9e813fa View commit details
    Browse the repository at this point in the history

  3. refactor: LazyString versions of Fix

    @MilesCranmer
    MilesCranmer committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    04dfe09 View commit details
    Browse the repository at this point in the history

  4. docs: tweak compat statement

    @MilesCranmer
    MilesCranmer committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6cac583 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fixN

    @MilesCranmer
    MilesCranmer authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0271f75 View commit details
    Browse the repository at this point in the history

  6. docs: update NEWS.md with removed keyword arg functionality

    @MilesCranmer
    MilesCranmer authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ed64473 View commit details
    Browse the repository at this point in the history

  7. fix: change in specialization from _stable_typeof

    @MilesCranmer
    MilesCranmer committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4999c2f View commit details
    Browse the repository at this point in the history

  8. Revert "fix: change in specialization from _stable_typeof" 

    This reverts commit 4999c2f.
    @MilesCranmer
    MilesCranmer committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c7aebb3 View commit details
    Browse the repository at this point in the history

  9. test: add back in test

    @MilesCranmer
    MilesCranmer committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    8c9f62f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Merge branch 'master' into fixN

    @LilithHafner
    LilithHafner authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f065c33 View commit details
    Browse the repository at this point in the history