switch effect analysis to snake case #54315
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was formed by running a bunch of global find-and-replaces
And manually updating the public
@assume_effects
macro to continue accepting the old symbols as arguments.From discussion on Zulip (https://julialang.zulipchat.com/#narrow/stream/137791-general/topic/About.2Ejl/near/436262421)
This seems worth doing in the light of the inconsistency between
inaccessiblememonly
andeffect_free
and the fact that effect analysis is slowly becoming public.Very open to adjusting the scope of this PR/how much we rename. I leaned pretty far into making all the effect analysis snake case in this first draft to see what folks think and to avoid having to make followups.