Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make loading work with a entryfile entry in the manifest file #53939

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Apr 3, 2024

also soft deprecate the path entry in project file in favour of using entrypath instead

Fixes the Julia Base part of #53937

also soft deprecate the `path` entry in project file in favour of using `entrypath` instead
@KristofferC KristofferC requested a review from Keno April 3, 2024 13:07
@KristofferC
Copy link
Member Author

Pkg PR is at JuliaLang/Pkg.jl#3850.

Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried it out, but from my understanding of the loading code this is reasonable. I do like the path/entrypath disambiguation. Probably should have docs somewhere though.

@KristofferC
Copy link
Member Author

I added an entry to the docs. Please see if it is understandable.

@Keno
Copy link
Member

Keno commented Apr 3, 2024

Docs look fine to me.

@KristofferC
Copy link
Member Author

I'm thinking entryfile is better than entrypath. It is a little bit strange to have path and entrypath but having path and entryfile makes sense. (entrypath is then naturally joinpath(path, entryfile).)

@KristofferC KristofferC changed the title make loading work with a entrypath entry in the manifest file make loading work with a entryfile entry in the manifest file Apr 5, 2024
@KristofferC KristofferC merged commit 5f4dec1 into master Apr 5, 2024
8 checks passed
@KristofferC KristofferC deleted the kc/entrypath branch April 5, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants