Implement proper macro scope resolution for generator/for

[Keno]

I'm not super familiar with this code, but it appears to me that these need to be treated as equivalent to implicit let blocks for the purposes of macro hygiene, so add appropriate logic to the macroexpander. Fixes #53673.

[Keno]

@nanosoldier runtests()

[nanosoldier]

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

[Keno]

@nanosoldier runtests(["SmartAsserts", "UncertainEvidence", "GeneralizedRouwenhorst", "ConvexFit", "UnbalancedOptimalTransport", "ProgressMeter", "JMcDM", "MathProgBase", "PseudoBooleanOptimization", "AddInit", "Bonobo", "CMAEvolutionStrategy", "MbedTLS", "Flamenco", "DistributedArrays", "MultivariateBases", "SemialgebraicSets", "GeometricTheoremProver", "ConstraintTrees", "PolynomialTestSystems", "AffineArithmetic", "SimplicialCubature", "PolynomialsMutableArithmetics", "IteratedIntegration", "StaticPolynomials", "CarlemanLinearization", "MixedSubdivisions", "JackPolynomials", "PolyhedralOmega", "SelfOrganizingMaps", "SubpixelRegistration", "SBML", "MathematicalSystems", "DataInterpolations", "Insolation", "LegendrePolynomials", "MadNLPKrylov", "SymEngine", "MultivariateMoments", "ImplicitPlots", "MadNLPPardiso", "MadNLPMumps", "HybridSystems", "ExaTron", "SymbolicWedderburn", "FMIImport", "BenchmarkProfiles", "SymPyCore", "TrustRegionMethods", "LineSearches", "SphericalHarmonicExpansions", "Experimenter", "NonsmoothOptim", "Knapsacks", "BundleMethod", "ParametricLP", "CutPruners", "LinearFractional", "ComplexOptInterface", "PiecewiseLinearOpt", "MultiwayNumberPartitioning", "vOptGeneric", "JuDGE", "PolyhedralRelaxations", "EfficientFrontier", "BirkhoffDecomposition", "CorrelatedEquilibria", "OperationsResearchModels", "DisjunctiveProgramming", "NonogramSolver", "GLPKMathProgInterface", "Fri", "SparseVariables", "SymPy", "MiniZinc", "MultiJuMP", "StatsDiscretizations", "SymPyPythonCall", "UnitJuMP", "Dualization", "MultiObjectiveAlgorithms", "NLopt", "GraphOptInterface", "OOESAlgorithm", "InfrastructureModels", "QuantumCircuitOpt", "FindMinimaxPolynomial", "MathProgIncidence", "PerfectPacking", "AmplNLWriter", "LightGraphsFlows", "StatusSwitchingQP", "MultistartOptimization", "MAiNGO", "CSDP", "Pavito", "Allocations", "GraphsFlows", "OSQP", "RobustFactorizations", "ParamPunPam", "ECOS", "Markets", "DAQP", "SeparableOptimization", "VarianceComponentModels", "PetroleumModels", "Convex", "SCS", "StandaloneIpopt", "SDPLR", "GuessworkQuantumSideInfo", "YasolSolver", "SecretSanta", "ApproximateVanishingIdeals", "ReverseMcCormick", "NLSProblems", "SchattenNorms", "PolyDAQP", "Vecchia", "BlockDecomposition", "ChooseOptimizer", "Hyperopt", "Sudoku", "GLPK", "Clp", "NOMAD", "Ipopt", "SymbolicLimits", "LatinSquares", "LoopTools", "ShiftedProximalOperators", "LovaszTheta", "HCIToolbox", "LikelihoodProfiler", "LightGraphsMatching", "GraphsMatching", "PoGO", "Chordal", "SimpleWorkflowRecipes", "StrategicGames", "LongestPaths", "ModelOrderReductionToolkit", "DiscreteFunctions", "OnlinePortfolioSelection", "Cbc", "RecoverPose", "SymbolicCodegen", "NEOSServer", "WaterModels", "PATHSolver", "BoxCoxTrans", "Basinhopping", "ProximalMethods", "GARCH", "TheCannon", "CompressedSensing", "NLPModelsIpopt", "ExactOptimalTransport", "SupportPoints", "BDisposal", "DecisionProgramming", "GasModels", "DataAssim", "PGLib", "FrankWolfe", "LRSLib", "ProximalOperators", "FaSTLMM", "EnergyModelsBase", "PowerModelsAnnex", "LeastSquaresOptim", "CALiPPSO", "PCCAPlus", "EnergyModelsRenewableProducers", "EnergyModelsGeography", "PWF", "PowerModelsSecurityConstrained", "EnergyModelsInvestments", "BranchAndBound", "PolyhedralCubature", "PowerModelsMCDC", "PowerModelsRestoration", "PowerModels", "ProgressiveHedging", "VoronoiGraph", "Powersense", "ProjectAssigner", "FlexPlan", "PowerModelsADA", "BioGraph", "PowerModelsACDC", "BaytesOptim", "RiskMeasures", "ScalingCollapse", "PSFModels", "RealTimeScheduling", "CameraModels", "OpSel", "RevealedPreferences", "SDDP", "PowerModelsStability", "QUnfold", "Miletus", "QuantumWalk", "CbaOPF", "LiftAndLearn", "BaytesSMC", "SCTransform", "QHull", "OPFSampler", "TimetableSolver", "BlackBoxOptimizationBenchmarking", "LPVSpectral", "GtkObservables", "HyperModularity", "HallThruster", "LiteHF", "CountTimeSeries", "RheaMetacycParser", "CDDLib", "Complementarity", "GittinsIndices", "ElectricFields", "ScoreDrivenModels", "EquivalentCircuits", "MixedLRMoE", "Algames", "RoundAndSwap", "PolynomialAmoebas", "CharFuncPricing", "PowerModelsDistribution", "PandaModels", "Survival", "CalibrationErrorsDistributions", "FBCModelTests", "GasPowerModels", "HCGeoTherm", "LRMoE", "ClimateMARGO", "CommonOPF", "TulipaEnergyModel", "SumOfSquares", "BenchmarkingEconomicEfficiency", "PowerModelsProtection", "BlankLocalizationCore", "SymmetryReduceBZ", "Baytes", "AnyMOD", "OptimizationNOMAD", "DataEnvelopmentAnalysis", "StateSpaceModels", "Equate", "OptimizationPolyalgorithms", "Anneal", "GaussianMixtureAlignment", "InvariantSets", "NetDecOPF", "PowerModelsITD", "SynthControl", "InteractiveFixedEffectModels", "sparseQFCA", "E4ST", "LinRegOutliers", "RadiationSpectra", "IsingSolvers", "QUBO", "QUBODrivers", "OPFLearn", "BasisMatrices", "RobustModels", "QuantEcon", "MetidaNLopt", "MetidaFreq", "MQLib", "Autologistic", "MIPVerify", "QuartetNetworkGoodnessFit", "Metida", "CompEcon", "EclipsingBinaryStars", "UncertaintyQuantification", "PsychometricsBazaarBase", "ParallelAnalysis", "DWaveNeal", "ArviZ", "ConstraintModels", "MarriageMarkets", "CBLS", "TaylorModels", "GeoStatsModels", "SetProg", "Flowstar", "SignalAnalysis", "TaylorInversion", "RitSpls", "FuzzyCRegression", "GeoStatsBase", "NExOS", "EulerLagrange", "ReducedComplexityModeling", "DerivableFunctionsBase", "KeplerTools", "ParameterSpacePartitions", "OrdinalMultinomialModels", "JordanForm", "ReversePropagation", "SphericalFunctions", "IterativeLQR", "RandomFeatures", "SparseSensors", "FractionalCalculus", "SimplePosetAlgorithms", "PolaronMobility", "HarmonicPowerModels", "Pathfinder", "CompressiveLearning", "Unfolding", "MaximumEntropyMomentClosures", "ValueAtRisk", "MPISphericalHarmonics", "MathML", "GeoEstimation", "Photometry", "NetworkHawkesProcesses", "KdotP", "SingleCellProjections", "MathOptSymbolicAD", "PhyloDiamond", "GMMParameterEstimation", "Korg", "MolecularGaussians", "Extremes", "EquationsSolver", "GeneralizedMonteCarlo", "DifferentiableCollisions", "QuantitativeMRI", "PowerPlots", "LowLevelParticleFilters", "DoloYAML", "ClosedLoopReachability", "BEASTDataPrep", "Dolo", "QuasiCopula", "ThresholdStability", "RealPolyhedralHomotopy", "SwitchOnSafety", "NextGP", "MixedModelsPermutations", "SocialSamplingTheory", "JosephsonCircuits", "TensND", "GeoStatsValidation", "MetidaBioeq", "GeoStats", "StellaratorOptimization", "GeoStatsSolvers", "DirectTrajectoryOptimization", "VMEC", "ApproxManifoldProducts", "AlgamesDriving", "SymbolicControlSystems", "BloqadeDormandPrince", "Mikrubi", "BellDiagonalQudits", "GeometricProblems", "PETLION", "Phonetics", "BaseModelica", "StatisticalRethinking", "StochasticDelayDiffEq", "GameTheory", "NeuronBuilder", "IndependentComponentAnalysis", "ParameterizedFunctions", "Simpsons", "LocalAnisotropies", "UnfoldSim", "PlasmoPlots", "FSimZoo", "Scheduling", "BloqadeWaveforms", "DistributedRelaxationTimes", "BloqadeKrylov", "MNPDynamics", "ONSAS", "Petri", "LongMemory", "NMRAnalysis", "ChargeTransport", "LiquidElectrolytes", "Yunir", "BaytesInference", "Qwind", "TrajectoryGamesBase", "PortfolioAnalytics", "SymplecticMapTools", "MultiscaleGraphSignalTransforms", "MicroTracker", "SemanticTrajectories", "EnergyCommunity", "Biofilm", "FSimPlots", "MathepiaModels", "RigorousInvariantMeasures", "NeuroAnalysis"])

[vtjnash]

SGTM. But can you add a test for for local x and for outer x forms also, to make sure those don't error here because of the varlist call.

[nanosoldier]

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

[Keno]

for local x

I don't think we allow this form

julia> function foo()
       for local x = 1:2
       end
ERROR: end
ParseError:
# Error @ REPL[1]:2:18
function foo()
for local x = 1:2
#                └ ── invalid iteration spec: expected one of `=` `in` or `∈`
Stacktrace:
 [1] top-level scope
   @ none:1

[Keno]

@nanosoldier runtests(["SmartAsserts", "AddInit", "Experimenter", "ProgressMeter", "FindMinimaxPolynomial", "DistributedArrays", "BenchmarkingEconomicEfficiency", "SignalAnalysis", "ThresholdStability", "Flowstar", "HarmonicPowerModels", "SwitchOnSafety", "PhyloDiamond", "MetidaBioeq", "PETLION", "NMRAnalysis", "BloqadeWaveforms", "MicroTracker", "EnergyCommunity", "SemanticTrajectories"])

[nanosoldier]

The package evaluation job you requested has completed - no new issues were detected.
The full report is available.