“Fix” #53451 -- allow zero-row QR factorization bypassing LAPACK #53578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
reviewed
Mar 11, 2024
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Member
|
The newly added tests pass also in the failing windows run, so I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple fix for JuliaLang/LinearAlgebra.jl#1054, allowing for QR factorizations of zero-row matrices by bypassing LAPACK in case any matrix dimension is positive.
A few unit tests check both zero-column and zero-row matrices (including 0x0) for all relevant data types.
Built from source the tests seem to pass alright.
Fixes JuliaLang/LinearAlgebra.jl#1054.