enable less/edit for documented variables
#53539
Open
+44
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! Can this also locate struct definitions or other type declarations (at least if they are documented)? Then one could also partially resolve #38966 |
|
I presume this fixes #53534? |
Yes! In fact it already works if you give the name of a documented type, since those are treated the same as other bindings. It does not yet work for instantiated types like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't store the locations of definitions of variables, but the doc system does (when they are documented). This PR uses that info to make
lessandeditwork on variables.I'm not sure about the change to REPL. We copy metadata from the docsystem's objects to meta dicts in the markdown object, but for some reason we only copy certain fields. It seems to me that should include both the filename and line number. Then maybe the doc viewer could show locations.