-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
update libwhich to latest commit (from 2022/10) #53398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it supports more platforms.
I think you also need to first update Yggdrasil to build the latest commit also |
I don't think libwhich is in Yggdrasil. |
Should we add it to Yggdrasil? |
libwhich is a small tool that probably won't be used by anyone else in the julia ecosystem. Lines 49 to 53 in 61fc907
Line 12 in d12a620
|
I think it is a build-time only dep, right? If so, I don't really see a need to put it into Ygg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This moves libwhich from a commit made in November 2017 to the most recent (from October 2022), including fixes for OpenBSD and musl (?), so it seems indeed long overdue to do this. Hopefully won't cause regressions, but if the tests pass, should be merged.
However the mingw32 test is failing. I hope it's a fluke but it should be restarted to verify.
It supports more platforms. it is part of on-going work to port julia to OpenBSD.
It supports more platforms. it is part of on-going work to port julia to OpenBSD.
it supports more platforms.
it is part of on-going work to port julia to OpenBSD.