Skip to content

update libwhich to latest commit (from 2022/10) #53398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Feb 20, 2024

it supports more platforms.

it is part of on-going work to port julia to OpenBSD.

@inkydragon inkydragon added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Feb 20, 2024
@vtjnash
Copy link
Member

vtjnash commented Feb 20, 2024

I think you also need to first update Yggdrasil to build the latest commit also

@imciner2
Copy link
Contributor

I don't think libwhich is in Yggdrasil.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Feb 20, 2024
@ViralBShah
Copy link
Member

Should we add it to Yggdrasil?

@inkydragon
Copy link
Member

Should we add it to Yggdrasil?

libwhich is a small tool that probably won't be used by anyone else in the julia ecosystem.
It's fine for me to add it or not.

julia/THIRDPARTY.md

Lines 49 to 53 in 61fc907

Julia's build process uses the following external tools:
- [PATCHELF](https://github.com/NixOS/patchelf/blob/master/COPYING) [GPL3]
- [OBJCONV](https://www.agner.org/optimize/#objconv) [GPL3]
- [LIBWHICH](https://github.com/vtjnash/libwhich/blob/master/LICENSE) [MIT]

# Note: Some deps do not have a `_jll` pkg: [libwhich, patchelf, utf8proc]

@imciner2
Copy link
Contributor

I think it is a build-time only dep, right? If so, I don't really see a need to put it into Ygg.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moves libwhich from a commit made in November 2017 to the most recent (from October 2022), including fixes for OpenBSD and musl (?), so it seems indeed long overdue to do this. Hopefully won't cause regressions, but if the tests pass, should be merged.

However the mingw32 test is failing. I hope it's a fluke but it should be restarted to verify.

@vtjnash vtjnash merged commit ef8fab0 into JuliaLang:master Feb 21, 2024
@inkydragon inkydragon removed the merge me PR is reviewed. Merge when all tests are passing label Feb 21, 2024
@semarie semarie deleted the update-libwhich branch March 1, 2024 10:57
tecosaur pushed a commit to tecosaur/julia that referenced this pull request Mar 4, 2024
It supports more platforms.

it is part of on-going work to port julia to OpenBSD.
mkitti pushed a commit to mkitti/julia that referenced this pull request Mar 7, 2024
It supports more platforms.

it is part of on-going work to port julia to OpenBSD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants