Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add waitany and waitall functions to wait multiple tasks at once #53341

Merged
merged 30 commits into from
Mar 11, 2024
Merged

Add waitany and waitall functions to wait multiple tasks at once #53341

merged 30 commits into from
Mar 11, 2024

Commits on Mar 9, 2024

  1. Add waitany and waitall to wait multiple tasks

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    1fb6a95 View commit details
    Browse the repository at this point in the history

  2. Reduce the number of working vectors

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    7482838 View commit details
    Browse the repository at this point in the history

  3. Rewrite with using Channel

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    5a30999 View commit details
    Browse the repository at this point in the history

  4. Add test cases to Cover all argument types

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    664f8a3 View commit details
    Browse the repository at this point in the history

  5. Remove return type of _wait_multiple

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    8ac6ddc View commit details
    Browse the repository at this point in the history

  6. Remove 1st argument type of _wait_multiple 

    Instead of annotating the argument type, check the type of each actual element.

Co-authored-by: Shuhei Kadowaki <aviatesk@gmail.com>
    @mrkn @aviatesk
    mrkn and aviatesk committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    f459e8a View commit details
    Browse the repository at this point in the history

  7. Specify type of element that comes from iteration for type stability 

    Co-authored-by: Shuhei Kadowaki <aviatesk@gmail.com>
    @mrkn @aviatesk
    mrkn and aviatesk committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    eb2bafd View commit details
    Browse the repository at this point in the history

  8. Support inputs that can be iterated only once 

    Co-authored-by: Shuhei Kadowaki <aviatesk@gmail.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @aviatesk @vtjnash
    3 people committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    d7cf9dc View commit details
    Browse the repository at this point in the history

  9. Delete waiters from waitq of each remaining task 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    9159247 View commit details
    Browse the repository at this point in the history

  10. Fix for performance 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    573ee9f View commit details
    Browse the repository at this point in the history

  11. Split type checking and examining loops 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    1175779 View commit details
    Browse the repository at this point in the history

  12. Stop using needless enumerate

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    633cb58 View commit details
    Browse the repository at this point in the history

  13. Optimize for waitall with failfast=false 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    4bec8cd View commit details
    Browse the repository at this point in the history

  14. Use vector for managing waiters 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    b9dd9e6 View commit details
    Browse the repository at this point in the history

  15. Add channel emptiness check 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    ae0ca9d View commit details
    Browse the repository at this point in the history

  16. Insert done check in waiter creation loop 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    93057e6 View commit details
    Browse the repository at this point in the history

  17. Stop using kwargs in _wait_multiple

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    ed58eda View commit details
    Browse the repository at this point in the history

  18. Add throw keyword argument in waitall

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    f1f400e View commit details
    Browse the repository at this point in the history

  19. Add throw keyword argument in waitany

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    4d8e137 View commit details
    Browse the repository at this point in the history

  20. Add docstrings of waitany and waitall

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    1a55697 View commit details
    Browse the repository at this point in the history

  21. Wait single task synchronously

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    22646dd View commit details
    Browse the repository at this point in the history

  22. Use TaskFailedException 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    505d476 View commit details
    Browse the repository at this point in the history

  23. Stop using sleep in test 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    1c9adbf View commit details
    Browse the repository at this point in the history

  24. Remove needless yield call 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    58d1e02 View commit details
    Browse the repository at this point in the history

  25. Wait all three tasks in teardown function in test 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    3c9a9c8 View commit details
    Browse the repository at this point in the history

  26. Use consistent declarative tense in docstring

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    4dd8862 View commit details
    Browse the repository at this point in the history

  27. Add waitany and waitall in doc/src/base/parallel.md

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    34e3d41 View commit details
    Browse the repository at this point in the history

  28. Add waitany and waitall in NEWS.md

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    8a7683f View commit details
    Browse the repository at this point in the history

  29. Change default argument values

    @mrkn
    mrkn committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    d30c9c0 View commit details
    Browse the repository at this point in the history

  30. Add usage note of waitall in docstring 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @mrkn @vtjnash
    mrkn and vtjnash committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    0a382a3 View commit details
    Browse the repository at this point in the history