Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve printing for length and size method error #53146

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 1, 2024

Updates/Closes #25339, using the new register_error_hint ability (@kdheepak)
Fixes #25232

What is somewhat interesting about this case, is it seems like one of the first cases where the MethodError tries to identify the applicable interface being used and point out which other methods to implement

Updates/Closes #25339, using the new register_error_hint ability
Fixes #25232
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing error messages Better, more actionable error messages labels Feb 1, 2024
Copy link
Contributor

@Seelengrab Seelengrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small "indicate this is code" suggestion :)

base/errorshow.jl Outdated Show resolved Hide resolved
base/errorshow.jl Outdated Show resolved Hide resolved
test/errorshow.jl Outdated Show resolved Hide resolved
test/errorshow.jl Outdated Show resolved Hide resolved
Co-authored-by: Sukera <11753998+Seelengrab@users.noreply.github.com>
@IanButterworth IanButterworth merged commit 3d8b107 into master Feb 4, 2024
7 checks passed
@IanButterworth IanButterworth deleted the jn/25339 branch February 4, 2024 03:58
@inkydragon inkydragon removed the merge me PR is reviewed. Merge when all tests are passing label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error messages Better, more actionable error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add special printing for length method error
5 participants