Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: make loading of extensions independent of what packages are in the sysimage #52841

Merged
merged 5 commits into from
Jan 29, 2024

Commits on Jan 10, 2024

  1. Extensions: make loading of extensions independent of what packages a…

    …re in the sysimage
    
    When triggers of extension are in the sysimage it is easy to end up with cycles in package loading.
    Say we have a package A with exts BExt and CExt and say that B and C is in the sysimage.
    
    - Upon loading A, we will immidiately start to precompile BExt (because the trigger B is "loaded" by virtue of being in the sysimage).
    - BExt will load A which will cause CExt to start precompiling (again because C is in the sysimage).
    - CExt will load A which will now cause BExt to start loading and we get a cycle.
    
    This is fixed in this PR by instead of looking at what modules are loaded, we look at what modules are actually `require`d
    and only use that to drive the loading of extensions.
    KristofferC committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    e36c0de View commit details
    Browse the repository at this point in the history
  2. woops

    KristofferC committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    be8fe90 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. alt implementation

    KristofferC committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    6be9189 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    36213eb View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. add a test

    KristofferC committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7780975 View commit details
    Browse the repository at this point in the history