Added tests for Base.copy!

[AmanDoesntCode]

Testing the deep copying of Sets, Dictionaries and arrays was necessary. Added tests for Base.copy!

[AmanDoesntCode]

For some reason test x86_64-w64-mingw32 bash .buildkite/utilities/test_julia.sh is failing in the tests by buildkite. i686 works perfectly fine. Since this is my first PR I would really appreciate it if a reviewer might help me out. I closed the same PR once before because of some unwanted commits for this PR. I am enjoying the spirits over here and am looking forward to contribute more for Julia.

[AmanDoesntCode]

Hey @shashi what must I do ? To make the change happen and add these tests. Kindly help me out here... I am really new to contributing. Is there something I overlooked/misunderstood from the contribution pathways ?

[vtjnash]

Looks like there was just some issues with the buildkite runner that don't impact your PR. Could you move these to a different test file, such as test/copy.jl? It doesn't look like these have anything to do with the Future's module.

[AmanDoesntCode]

Sure, would do it ASAP.

[AmanDoesntCode]

@vtjnash Seems like there already is one copy.jl that is much more able in testing the copy! but for different issues do I still add these basic tests for it ?

[vtjnash]

Yes, just append them to the end of it. Side question: how did you determine these needed tests, and is there a relevant issue that should be closed now?

[inkydragon]

The tests for copy! are generally associated with the type of input, which is probably why copy.jl does not contain tests for copy!.

julia/test/abstractarray.jl

Lines 1077 to 1094 in af90dac

	@testset "copy!" begin
	@testset "AbstractVector" begin
	s = Vector([1, 2])
	for a = ([1], UInt[1], [3, 4, 5], UInt[3, 4, 5])
	@test s === copy!(s, Vector(a)) == Vector(a)
	end
	# issue #35649
	s = [1, 2, 3, 4]
	s2 = reshape(s, 2, 2) # shared data
	@test s === copy!(s, 11:14) == 11:14
	end
	@testset "AbstractArray" begin
	@test_throws ArgumentError copy!(zeros(2, 3), zeros(3, 2))
	s = zeros(2, 2)
	@test s === copy!(s, fill(1, 2, 2)) == fill(1, 2, 2)
	@test s === copy!(s, fill(1.0, 2, 2)) == fill(1.0, 2, 2)
	end
	end

julia/test/dict.jl

Lines 1420 to 1430 in af90dac

	@testset "copy!" begin
	s = Dict(1=>2, 2=>3)
	for a = ([3=>4], [0x3=>0x4], [3=>4, 5=>6, 7=>8], Pair{UInt,UInt}[3=>4, 5=>6, 7=>8])
	@test s === copy!(s, Dict(a)) == Dict(a)
	if length(a) == 1 # current limitation of Base.ImmutableDict
	@test s === copy!(s, Base.ImmutableDict(a[])) == Dict(a[])
	end
	end
	s2 = copy(s)
	@test copy!(s, s) == s2
	end

julia/test/sets.jl

Lines 179 to 190 in af90dac

	@testset "copy!" begin
	for S = (Set, BitSet)
	s = S([1, 2])
	for a = ([1], UInt[1], [3, 4, 5], UInt[3, 4, 5])
	@test s === copy!(s, Set(a)) == S(a)
	@test s === copy!(s, BitSet(a)) == S(a)
	end
	end
	s = Set([1, 2])
	s2 = copy(s)
	@test copy!(s, s) == s2
	end

[AmanDoesntCode]

Ok then I feel like it still is kind of needed to be added in the copy.jl since there is no unit display of the usecase through tests. @inkydragon

[AmanDoesntCode]

@vtjnash I have appended the same code in copy.jl and have emptied the future test folder. Do tell me if I have to do anything else.

Answering the side note :
I was learning the documentation and saw the comment that says "This function has moved to Base with Julia 1.1, consider using copy!(dst, src) instead. Future.copy! will be deprecated in the future." So it just appeared to me that there should be test cases to check out the basic functioning of the method.

[vtjnash]

It looks like @inkydragon is correct that these methods appear to already be covered in the original PR: #29178

Is there anything there that this covers that isn't already covered? It doesn't look like we need these added tests

[AmanDoesntCode]

@vtjnash Absolutely ! The tests for a language must be concise and not confusing. I do not see any issues being covered here. I am really grateful to all of the reviewers to put their attention to my first PR towards Julia. I will try to be more aware next time.