Add more @showarg examples #52410
Merged
Add more @showarg examples #52410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a few more examples to show how @showarg works with literals and interpolated string expressions.
fingolfin
approved these changes
Feb 10, 2024
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
I find the selection of examples a bit arbitrary but if you find it helpful, why not :-)
Member
|
The docstring REPL does not permit these sort of inline comments. I am not sure this is that useful, since it is also just showing that different expressions parse differently, which is probably explained elsewhere (though I agree that it can take a while to fully appreciate the implications of that) |
fingolfin
reviewed
Feb 12, 2024
Member
|
@vtjnash that's a valid argument against merging this, of course. So who makes the decision whether to reject this, or whether to ask for further improvements? I personally could live with either, but we should not leave @bluesmoon hanging |
Contributor
Author
|
I'll update the MR. |
docstring REPL does not like inline comments on a line by itself, so move the comments to the code line (the line with the `julia>` prompt)
Contributor
Author
|
I've updated the MR with @vtjnash's & @fingolfin's suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few more examples to show how @showarg works with literals and interpolated string expressions.