Generalize Diagonal * AdjOrTransAbsMat to arbitrary element types #52389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation assumes that the adjoint matrix may be copied to the destination, but this is not necessary in general. This PR
changes the implementation to useremoves the specialized methods, so that the multiplication generalizes to arbitrary element types. In particular, the following works after this:mul!
instead ofcopy
+(l/r)mul!