Skip to content

Mark the indexing as @inbounds in triu! #52117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

Mark the indexing as @inbounds in triu! #52117

merged 1 commit into from
Nov 10, 2023

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Nov 10, 2023

The corresponding line in tril! is also marked @inbounds, so I think this makes sense.

Performance difference:

julia> @btime triu!($(rand(100,100)), 0);
  1.382 μs (0 allocations: 0 bytes) # master
  629.723 ns (0 allocations: 0 bytes) # PR

@jishnub jishnub added linear algebra Linear algebra arrays [a, r, r, a, y, s] labels Nov 10, 2023
@dkarrasch dkarrasch merged commit 8944a22 into master Nov 10, 2023
@dkarrasch dkarrasch deleted the jishnub/triuinbounds branch November 10, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

+1 more reviewer

@Seelengrab Seelengrab Seelengrab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arrays [a, r, r, a, y, s] linear algebra Linear algebra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jishnub @Seelengrab @dkarrasch