effects: improve idempotency of effects derived by post-opt analysis #52085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Nov 8, 2023
aviatesk
force-pushed
the
avi/post-opt-idempotency
branch
2 times, most recently
from
7a60dca to
26000d3
Compare
aviatesk
commented
Nov 9, 2023
| k43296(b, j, ::Nothing) = b | ||
| i43296(b, j) = k43296(b, j, r43296(j)) | ||
| @test only(Base.return_types(i43296, (Int, C43296{C43296{C43296{Val, Tuple}, Tuple}}))) == Int | ||
| @test only(Base.return_types(i43296, (Int, C43296{C43296{C43296{Val, Tuple}}}))) <: Int |
Member
Author
There was a problem hiding this comment.
This call signature would always result in an error, which can now be discovered by concrete-evaluation.
|
|
||
| # inlining with unmatched type parameters | ||
| @eval struct OldVal{T} | ||
| x::T |
Member
Author
There was a problem hiding this comment.
The previous definition was actually invalid, causing segfault when concretized.
aviatesk
force-pushed
the
avi/post-opt-idempotency
branch
from
26000d3 to
99b8a2c
Compare
Since now effects can be refined by post-opt analysis, `typeinf_edge` should propagate `frame.result.ipo_effects` instead of `frame.ipo_effects`.
aviatesk
force-pushed
the
avi/post-opt-idempotency
branch
from
99b8a2c to
358540c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since now effects can be refined by post-opt analysis,
typeinf_edgeshould propagateframe.result.ipo_effectsinstead offrame.ipo_effects.