Skip to content

minor fix on getfield_nothrow #52083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

minor fix on getfield_nothrow #52083

merged 1 commit into from
Nov 9, 2023

Conversation

@aviatesk
Copy link
Member

@aviatesk aviatesk commented Nov 8, 2023

  • fixed index of order when there are 5 arguments
  • add type check for boundscheck argument

@aviatesk
minor fix on getfield_nothrow
ecdd5b5 
- fixed index of `order` when there are 5 arguments
- add type check for `boundscheck` argument
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Nov 8, 2023
@oscardssmith oscardssmith added bugfix This change fixes an existing bug compiler:effects effect analysis labels Nov 8, 2023
@N5N3 N5N3 merged commit 7309756 into master Nov 9, 2023
@N5N3 N5N3 deleted the avi/getfield_nothrow branch November 9, 2023 02:48
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix This change fixes an existing bug compiler:effects effect analysis

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aviatesk @vtjnash @oscardssmith @N5N3